Add Events for Policy Service APIs #2479
Merged
+255
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
reviewed
Sep 3, 2025
| return resp; | ||
| } | ||
|
|
||
| private String getCatalogFromPrefix(String prefix, RealmContext realmContext) { |
| public class CatalogPolicyServiceEvents { | ||
|
|
||
| // Policy CRUD Events | ||
| public record BeforeCreatePolicyEvent( |
There was a problem hiding this comment.
Sorry to insist on naming, but it's still inconsistent.
In #2482 we have (Before|After)(Object)(Verb)Event. E.g. BeforeCatalogListEvent.
Here we have (Before|After)(Verb)(Object)Event. E.g. BeforeCreatePolicyEvent.
(I find verb-object more natural than object-verb btw, but I'll defer the decision to native English speakers.)
There was a problem hiding this comment.
Thinking about it again, I think verb-object is better too. Let me keep these events as-is in that case and change the rest of the PRs.
adnanhemani
force-pushed
the
ahemani/event_instrumentation_catalog_policy_service
branch
from
16960b3 to
b4777fd
Compare
HonahX
previously approved these changes
Sep 4, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
adutra
previously approved these changes
Sep 4, 2025
+1 to the idea. |
sfc-gh-jojiang
approved these changes
Sep 5, 2025
HonahX
approved these changes
Sep 5, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Events instrumentation for the Policy Service APIs, surrounding the default delegated call to the business logic APIs.