Add unit tests for JsonIndexHandler index lifecycle#19045
Open
Akanksha-kedia wants to merge 4 commits into
Open
Add unit tests for JsonIndexHandler index lifecycle#19045Akanksha-kedia wants to merge 4 commits into
Akanksha-kedia wants to merge 4 commits into
Conversation
JsonIndexHandler had no unit test coverage. Adds JsonIndexHandlerTest with 5 tests covering: - Column dropped from config triggers index removal - updateIndices removes index for dropped column - New column with metadata present triggers index creation - Column in config but metadata absent skips index creation - Index already present and in config requires no update Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…dler preconditions Stub getTotalDocs()→1 and getAllColumns()→TreeSet in all SegmentMetadataImpl mocks so the BaseIndexHandler constructor precondition check does not throw.
…Javadoc; drop section dividers
Contributor
Author
|
cc @Jackie-Jiang @richardstartin — would appreciate a review when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
JsonIndexHandler, closing the coverage gap for the JSON index handler.Test cases covered:
updateIndicesverifiesremoveIndexis called)This is part of the same series as:
IFSTIndexHandlerFSTIndexHandlerRangeIndexHandlerTest plan
JsonIndexHandlerTestpasses locally