PHOENIX-7933 Avoid using reflection to initialize ServerCacheFactory#2539
Open
virajjasani wants to merge 1 commit into
Open
PHOENIX-7933 Avoid using reflection to initialize ServerCacheFactory#2539virajjasani wants to merge 1 commit into
virajjasani wants to merge 1 commit into
Conversation
Contributor
Author
palashc
approved these changes
Jun 20, 2026
| } else if (IndexMetaDataCacheFactory.class.getName().equals(factoryClassName)) { | ||
| cacheFactory = new IndexMetaDataCacheFactory(); | ||
| } else { | ||
| throw new DoNotRetryIOException("Disallowed ServerCacheFactory class: " + factoryClassName); |
Contributor
There was a problem hiding this comment.
nit: is it possible to add a test for this branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: PHOENIX-7933
What changes were proposed in this pull request?
ServerCacheFactory does not need reflection based initialization as we have only two implementations. For foreseeable future, we do not expect to add more implementations.
Why are the changes needed?
Using reflection is overhead as we don't expect more implementations of ServerCacheFactory.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UTs, ITs
Was this patch authored or co-authored using generative AI tooling?
No