inline some functions used in parsing #829
Conversation
add safeByteChar scalafmt
There was a problem hiding this comment.
Not worth it without a proper benchmark showing significant benefits. For these simple and small methods, static inlining is most likely a net negative with increases code size, duplication and complexity vs. a most obvious inlining opportunity in the jit inliner.
| * Used in places where we know that the index is valid because we checked the length beforehand. | ||
| */ | ||
| @inline | ||
| private[http] def safeByteChar(input: ByteString, ix: Int): Char = |
There was a problem hiding this comment.
@jrudolph thanks for the review. I can look at doing a jmh benchmark but it will take me a week or 2 to get back to it.
One question though: do you think the safeByteChar function is a useful change instead of having a few places in our code where we do the masking in place while usually, we call the byteChar function below? There are places where we know it safe so that we don't need to waste a call on checking the index is in bounds.
2 participants
Scala 2 and 3 have different ways to inline so I split the classes into Scala 2 and 3 variants.