clear warnings in http-core #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
force-pushed
the
clear-some-warnings
branch
2 times, most recently
from
ee51463 to
7a7ef21
Compare
|
@jrudolph Should this be reviewed? |
|
@jrudolph would you mind me merge your changes and push it，or you will do it sometime later? |
|
@mdedetrich @pjfanning I think we can continue this and includes it in 1.1.0 |
|
Some of them are fixed already. I think we can continue dev on Pekko HTTP for a few more days but the aim is to do a 1.1.0 release when Pekkko 1.1.1 is released. |
Just re-iterating that we shouldn't do a release of Pekko Http until #590 (review) is addressed |
# Conflicts: # http-core/src/main/scala/org/apache/pekko/http/impl/engine/rendering/RenderSupport.scala # http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpEntity.scala # http-core/src/test/scala/org/apache/pekko/http/impl/engine/client/LowLevelOutgoingConnectionSpec.scala # http-core/src/test/scala/org/apache/pekko/http/impl/model/parser/HttpHeaderSpec.scala # project/Common.scala
jrudolph
force-pushed
the
clear-some-warnings
branch
from
7a7ef21 to
79ca0ad
Compare
|
I guess, not worth pursuing further, right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.