HDDS-15958. Return InvalidURI for unreadable S3 object keys on GetObject#10860
Open
Gargi-jais11 wants to merge 1 commit into
Open
HDDS-15958. Return InvalidURI for unreadable S3 object keys on GetObject#10860Gargi-jais11 wants to merge 1 commit into
Gargi-jais11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
S3 Gateway returns
404 NoSuchKeyfor GetObject requests with unreadable/invalid object keys, instead of400 InvalidURIas AWS S3 does.Ozone already defines the correct error in S3ErrorTable.INVALID_URI but never uses it:
INVALID_URI("InvalidURI", "Couldn't parse the specified URI.", HTTP_BAD_REQUEST)The key \xae\x8a- contains non-printable high bytes (\x80–\xff) that Ozone cannot store and that AWS treats as an invalid URI. S3G should reject it before OM lookup.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15958
How was this patch tested?
Add Unit and Integration Tests.