HDDS-10315. Speed up TestContainerReplication#10858
Open
cychiu8 wants to merge 4 commits into
Open
Conversation
…r (legacyEnabled)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactors the
TestContainerReplicationintegration test to reduce runtime and duplication.Reduce runtime:
legacyEnabledparameter is no longer used, so drop thelegacyEnabledparameter dimension:createConfiguration(boolean enableLegacy)becomescreateConfiguration().containerReplicationArguments()now yields(policyClass)instead of (policyClass, legacyEnabled), halving the parameterized runs.testContainerReplicationtotestRatisContainerReReplicationAfterDatanodeShutdownand added a Javadoc describing what it verifies.Cleanup:
TestDataUtil.createVolumeAndBucket(...)helper instead of hand-rolled volume/bucket setup.OzoneClientFactory.getRpcClient(conf)withcluster.newClient().newClusterhelper with the inlineMiniOzoneClusterbuilder.lookupKey(...)helper and folded into the existinglookupKeyFirstLocation(...). Dropped unused imports and a stale TODO.testECContainerReplicationdatanode setup.Original running time (223.7 s)
Running time After Refactor (140.8s): 82.9 s faster
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10315
How was this patch tested?
Ran the test suite:
Result: all tests passed.