HDDS-15931. Remove usage of internal netty metrics#10846
Open
rich7420 wants to merge 1 commit into
Open
Conversation
Replace the internal PlatformDependent.usedDirectMemory/maxDirectMemory calls in NettyMetrics with public API. usedDirectMemory now reads the default ByteBufAllocator's metric; maxDirectMemory mirrors Netty's resolution order (io.netty.maxDirectMemory property, then -XX:MaxDirectMemorySize, then max heap) using only public API and is resolved once and cached. Add TestNettyMetrics.
Contributor
Author
|
cc @chungen0126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It would be better to not use netty internal
maxDirectMemoryandusedDirectMemoryin NettyMetrics#getMetrics.usedDirectMemorycan be replaced by netty public api. For example:maxDirectMemorydepends on system property and jvm setting.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15931
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/29946173218