HDDS-15313. Increase snapshot diff default thresholds.#10385
Draft
SaketaChalamchala wants to merge 1 commit into
Draft
HDDS-15313. Increase snapshot diff default thresholds.#10385SaketaChalamchala wants to merge 1 commit into
SaketaChalamchala wants to merge 1 commit into
Conversation
SaketaChalamchala
added
the
snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increasing the following snapshot diff thresholds because these medium jobs have run into these limit pretty quickly during observation.
ozone.om.snapshot.diff.max.allowed.keys.changed.per.job=1000000000(current default os 10M) because this only represents an estimated number of keys to iterate which is just the sum of number of entries in the delta SST files. It's not the actual number of key we iterate with the bucket prefix to calculate the diff or the actual diff size.ozone.om.snapshot.diff.max.page.size=5000(current default is 1000) because currently both default page size and max page size have the same limit. It makes sense to have max > default so that default can be increased without having to change max too often.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15313
How was this patch tested?
Existing tests to should run successfully.