Add structured file-backed dataset sources - #338
Open
isaac-dasari wants to merge 2 commits into
Open
Conversation
Signed-off-by: isaac-dasari <74317395+isaac-dasari@users.noreply.github.com>
Member
|
@isaac-dasari would it possible to fix the conflicts? Thanks! |
jbonofre
self-requested a review
August 28, 2026 15:02
Signed-off-by: isaac-dasari <74317395+isaac-dasari@users.noreply.github.com>
Author
|
@jbonofre Thanks the conflicts with current main are resolved and the branch is updated. I also adapted the changes to the completed OSI → Ossie rename and reran the affected Python and Java test suites locally. The PR is mergeable again; the fork-triggered GitHub Actions runs are now pending approval. |
Member
|
@isaac-dasari awesome! Thanks! I will do a new pass. |
khush-bhatia
reviewed
Sep 2, 2026
Comment on lines
+143
to
+150
| File-backed datasets may use an explicit structured form. `kind` is the discriminator; the initial portable file form requires a physical format and at least one location: | ||
|
|
||
| ```yaml | ||
| source: | ||
| kind: file | ||
| format: parquet | ||
| locations: | ||
| - s3://analytics-data/orders/*.parquet |
Contributor
There was a problem hiding this comment.
This is a great enhancement to the spec. But how about we generallize this such that it can support any catalog type (Hive, Polaris etc.. ) and then format can be parquet , table or sql query
Examples:
kind: file
format: parquet
locations:
- s3://analytics-data/orders/*.parquet
kind: HIVE_CATALOG
format: table
identifier: db.schema.table
kind: SNOWFLAKE_CATALOG
format: SQL_QUERY
query: 'select * from db.schema.table where col1 >10'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft adds a backward-compatible structured representation for file-backed datasets in
Dataset.sourcewhile preserving all existing string source forms.