Draft
Conversation
use AUDIOIOC_GETAUDIOINFO get current audio format Signed-off-by: yangyalei <yangyalei@xiaomi.com>
enable use AUDIOIOC_GETSTATE get lower driver state Signed-off-by: yangyalei <yangyalei@xiaomi.com>
support maintain apb buffer in upper half driver Signed-off-by: yangyalei <yangyalei@xiaomi.com>
support maintain apb buffer in upper driver Signed-off-by: yangyalei <yangyalei@xiaomi.com>
Add Hw pointer recored apb buffer read/write position Signed-off-by: yangyalei <yangyalei@xiaomi.com>
1. mmap hw_ptr_s, 2. mmap apb buffers; Signed-off-by: yangyalei <yangyalei@xiaomi.com>
protect hwpter in lock Signed-off-by: yangyalei <yangyalei@xiaomi.com>
support poll notify read/write enable Signed-off-by: yangyalei <yangyalei@xiaomi.com>
modify to keep code clean Signed-off-by: yangyalei <yangyalei@xiaomi.com>
relayout the code for easy modification Signed-off-by: yangyalei <yangyalei@xiaomi.com>
protect configure lower only once Signed-off-by: yangyalei <yangyalei@xiaomi.com>
support multiple applications using upper at the same time Signed-off-by: yangyalei <yangyalei@xiaomi.com>
update aplication pointer in enqueuebuffer Signed-off-by: yangyalei <yangyalei@xiaomi.com>
in some case, draining have done in audio_stop Signed-off-by: yangyalei <yangyalei@xiaomi.com>
if another application has already been initialized, we do not stop the driver to facilitate a quick start. Signed-off-by: yangyalei <yangyalei@xiaomi.com>
memset apb buffer to zero when dequeue Signed-off-by: yangyalei <yangyalei@xiaomi.com>
notify POLLERR event if buffer drain Signed-off-by: yangyalei <yangyalei@xiaomi.com>
use AUDIOIOC_RESETSTATUS to reset application pointer Signed-off-by: yangyalei <yangyalei@xiaomi.com>
add 24 bit format define Signed-off-by: yangyalei <yangyalei@xiaomi.com>
memset audio info to zero when stop Signed-off-by: cenzhanquan1 <cenzhanquan1@xiaomi.com>
bug fix Signed-off-by: cenzhanquan1 <cenzhanquan1@xiaomi.com>
and compressed macros Signed-off-by: wurui3 <wurui3@xiaomi.com>
change use file_get Signed-off-by: jinxiuxu <jinxiuxu@xiaomi.com>
support upper driver check whether enqueue apb buffer to the lower driver Signed-off-by: yangyalei <yangyalei@xiaomi.com>
clear buffer only during playback when executing audio_dequeuebuffer Signed-off-by: yangyalei <yangyalei@xiaomi.com>
and lc3 enc & dec define Signed-off-by: cenzhanquan1 <cenzhanquan1@xiaomi.com>
support multiple applications simultaneously calling ALLOCATE_BUFFER Signed-off-by: fangyibo <fangyibo@xiaomi.com>
jump to ringbuffer tail in AUDIOIOC_RESETSTATUS Signed-off-by: fangyibo <fangyibo@xiaomi.com>
add float define Signed-off-by: fangyibo <fangyibo@xiaomi.com>
Inode_reserve will create intermediate directory automatically when register driver. Signed-off-by: wurui3 <wurui3@xiaomi.com>
Unregister an exsited audio device from filesystem. Signed-off-by: wurui3 <wurui3@xiaomi.com>
Support compressed data with LC3 and speex fmt. Signed-off-by: wurui3 <wurui3@xiaomi.com>
Compressed data with speex fmt is required to provide more info about codec. Signed-off-by: wurui3 <wurui3@xiaomi.com>
Sometimes cmd could not pass to lowerhalf if upperhalf is opened serveral times, add log to see the tue cmd passed. Signed-off-by: wurui3 <wurui3@xiaomi.com>
github-actions
bot
added
Area: Audio
Size: XL
linguini1
requested changes
Dec 9, 2025
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
This is a lot of commits, this PR needs to be split into multiple PRs. Please include detailed testing information and format the PR titles according to the same format as the commit topics.
jerpelea
requested changes
Dec 12, 2025
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
This amount of commits is hard to review
Please split the PR in logical blocks and submit separate PR for each one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
1、Add some log in upperhalf.
2、support more compressed data support in audio.
3、Add unregister audio devices support.
Impact
Upperhalf driver
Testing
We have conducted tests on the following platforms:
1、sim
2、bes
3、allwinnertech