include/string.h: mark memset and memcpy as used_code#17444
Open
raiden00pl wants to merge 1 commit intoapache:masterfrom
Open
include/string.h: mark memset and memcpy as used_code#17444raiden00pl wants to merge 1 commit intoapache:masterfrom
raiden00pl wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
I'm not sure if we should mark all memset implementations with |
Contributor
|
Alternative way is to add |
de9d837 to
6cbdc52
Compare
Mark memset and memcpy as used_code to fix issues with GCC LTO and CMake which throws many "undefined reference to memset" errors. used_code force the compiler to emit the memset symbol under LTO. Signed-off-by: raiden00pl <raiden00@railab.me>
xiaoxiang781216
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark memset and memcpy as used_code to fix issues with GCC LTO and CMake which throws many "undefined reference to memset" errors.
used_code force the compiler to emit the memset symbol under LTO.
Example error for libcxxabi:
Impact
fix LTO compilation
Testing
local build with LTO enabled