drivers/sensors/tc74ax: add driver for TC74Ax thermal sensor#17405
drivers/sensors/tc74ax: add driver for TC74Ax thermal sensor#17405cederom wants to merge 1 commit intoapache:masterfrom
Conversation
linguini1
left a comment
There was a problem hiding this comment.
I feel bad but should this not be a "uORB" sensor (uORB in quotes because it's just the new sensor framework)? This is what we're asking for from contributors going forward and I think it's counterproductive to keep merging legacy interfaces.
| #ifndef __ASSEMBLY__ | ||
|
|
||
| typedef enum | ||
| { |
There was a problem hiding this comment.
These should be in CAPS and also maybe a have a prefix unique to the sensor.
Thanks @linguini1, feedback forwarded to mailing list with additional references :-) |
This patch adds support for TC74 Tiny Serial Digital Thermal Sensor from Microchip. It is a standalone chip connected via I2C/SMBus. The driver was tested on AVR128DA28 chip using simple application that read the temperature from it and also switched it to/from standby state. IOCTL call used for power management borrows IOCTL code from another driver (ISL29023). Signed-off-by: Kerogit <kr.git@kerogit.eu>
|
Response from kerogit:
|
5867822 to
ae0d0ca
Compare
jerpelea
left a comment
There was a problem hiding this comment.
please resolve conflicts
Summary
PR delivered by kerogit over mailing list.
This patch adds support for TC74 Tiny Serial Digital Thermal Sensor from Microchip. It is a standalone chip connected via I2C/SMBus. Documentation for sensor is provided.
IOCTL call used for power management borrows IOCTL code from another driver (ISL29023).
Depends-on: #17403, #17404.
Impact
drivers/sensors: Adds support for TC74 Tiny Serial Digital Thermal Sensor from Microchip + Documentation.
Testing
The driver was tested on AVR128DA28 chip using simple application that read the temperature from it and also switched it to/from standby state.