Conversation
|
Hi @snikeguo, please read the guidelines for contributions https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md#15-commit-requirements A summary is also required for the PR https://github.com/apache/nuttx/blob/master/.github/PULL_REQUEST_TEMPLATE.md |
| { | ||
| FAR struct icmpv6_neighbor_advertise_s *adv; | ||
|
|
||
| bool should_process = false; |
There was a problem hiding this comment.
Suggestion: use a more explicit name, it helps people that will read this code in the future. I suggest using "is_for_this_node" instead of "should_process". Although in the "else" it tests for allnodes the packet needs to be handle locally. Other option could be "is_local_or_allnodes_dest"
| { | ||
| should_process = true; | ||
| } | ||
| else if (net_ipv6addr_cmp(ipv6->destipaddr, g_ipv6_allnodes)) |
There was a problem hiding this comment.
why not merge into one if statement
There was a problem hiding this comment.
Maybe this idea was to detect if received some NA and print display it
linguini1
left a comment
There was a problem hiding this comment.
Please fill out the PR according to the template.
cederom
left a comment
There was a problem hiding this comment.
Thank you @snikeguo, please read carefully the https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md, then update PR and git commits :-)
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.
Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.
For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the
adcexample. Adding a new uORB driver may require that you run
uorb_listenerto verify correct operation.Pure documentation changes can just be tested with
make html(see docs) and verification of the correct format in your
browser.
PRs without testing information will not be accepted. We will
request test logs.