-
Notifications
You must be signed in to change notification settings - Fork 645
game: Aligned Cmake with Make #3211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Conway's Game of Life apache#3210 Signed-off-by: simbit18 <[email protected]>
|
@simbit18 maybe we could create an automatic check: if a commit modify a Makefile but don't modify a CMakelist it raises an error |
|
Hi @acassis Let's start from the assumption that you can't be familiar with both build systems (Make and CMake). Make is the official build system. So, in my opinion, you can't block a PR if it's not aligned with CMake. In any community, you need to help each other by sharing your hard work! :) |
Yes, you are right! But in the other hand if we don't do it both building systems will be always out of sync. At some point we need to request support for board. Hmm, do you thing it is possible to have a script to keep CMake automatically synced with Make? |
If cmake script already exist, sync both build system is just simple copy and paste. I don't think there is any issue block the contributor sync them. The guide require that the contributor must fix the original coding style error and provide the full document, which is more work than sync build script. |
Agree! I think this is something that should be done later or during to review (the someone remember to ask to it) |
@acassis @xiaoxiang781216 Of course, if the CMakeList file exists, the change is minimal and easy to add. I was referring to all existing arch and boards (and all new ones to come) that currently do not have the CMake build system. |
the check could generate warning only when both CMakeLists.txt and Makefile exist. |
|
Sorry @simbit18 , I copied from the snake demo so I figured there was no CMake support for games yet. My next step was actually to go back and add it for the games, thanks for beating me to it! |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @simbit18 =)
Summary
Add:
Impact
Impact on user: NO
Impact on build: This PR Aligned Cmake with Make
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
Testing
locally