Skip to content

mbedtls: Add an option to build ssl_client2 test program #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

mbedtls: Add an option to build ssl_client2 test program #3165

merged 1 commit into from
Aug 28, 2025

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Aug 26, 2025

Summary

just for testing convenience.

Impact

Testing

tested on esp32s3-devkit while ago.

cederom
cederom previously approved these changes Aug 26, 2025
View reviewed changes
@yamt
Copy link
Contributor Author

yamt commented Aug 27, 2025 •
edited
Loading

the ci seems complaining on an untracked directory (crypto/mbedtls/mbedtls-framework/) for esp32s3-devkit/mbedtls.

i couldn't reproduce it locally. make distclean removed the directory. (macOS)

@yamt yamt dismissed stale reviews from cederom and xiaoxiang781216 via d2bffb6 August 27, 2025 05:50
@yamt yamt force-pushed the mbedtls-ssl-client2 branch from 96fe3a1 to d2bffb6 Compare August 27, 2025 05:50
@yamt
Copy link
Contributor Author

yamt commented Aug 27, 2025 •
edited
Loading

the ci seems complaining on an untracked directory (crypto/mbedtls/mbedtls-framework/) for esp32s3-devkit/mbedtls.

i couldn't reproduce it locally. make distclean removed the directory. (macOS)

maybe i misunderstood the error.
i guess it was from refresh_default, not distclean.
i added the directory to .gitignore.

@xiaoxiang781216 xiaoxiang781216 merged commit 0e65af6 into apache:master Aug 28, 2025
39 checks passed
@jerpelea
Copy link
Contributor

@xiaoxiang781216
commit d2bffb6 was merged without commit messages!

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 commit d2bffb6 was merged without commit messages!

sorry, I think the commit tile already express the modification clearly. If the commit message is an enforced rule, it's better to check in CI explicitly.

@cederom
Copy link
Contributor

cederom commented Aug 28, 2025

Yup, trivial update, but this will be verified by CI soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cederom cederom cederom approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
Area: Crypto Size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamt @jerpelea @xiaoxiang781216 @cederom