NIFI-15214 Refactor site-to-site-client using Java HttpClient #10522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15214 Refactors the
nifi-site-to-site-clientmodule and theSiteToSiteRestApiClientclass using the Java HttpClient, replacing and removing dependencies on synchronous and asynchronous Apache HttpClient 4 libraries.The refactored implementation includes a new unit test for the
SiteToSiteRestApiClientthat exercises public HTTP methods with OkHttp MockWebServer. Updates include moving URL string parsing to a separateClusterUrlParserclass.Additional changes include refactoring the
ClusterLoadBalanceAuthorizerto remove usage of the Apache HttpClientDefaultHostnameVerifier, adding direct comparison of wildcard-prefixed client certificate DNS Subject Alternative Names, with new unit tests to verify positive and negative checks.These changes enable removing Apache HttpClient 4 dependencies from the
nifi-framework-narand framework modules.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation