Skip to content

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15214 Refactors the nifi-site-to-site-client module and the SiteToSiteRestApiClient class using the Java HttpClient, replacing and removing dependencies on synchronous and asynchronous Apache HttpClient 4 libraries.

The refactored implementation includes a new unit test for the SiteToSiteRestApiClient that exercises public HTTP methods with OkHttp MockWebServer. Updates include moving URL string parsing to a separate ClusterUrlParser class.

Additional changes include refactoring the ClusterLoadBalanceAuthorizer to remove usage of the Apache HttpClient DefaultHostnameVerifier, adding direct comparison of wildcard-prefixed client certificate DNS Subject Alternative Names, with new unit tests to verify positive and negative checks.

These changes enable removing Apache HttpClient 4 dependencies from the nifi-framework-nar and framework modules.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Refactored ClusterLoadBalanceAuthorizer wildcard certificate verification
- Removed Apache HttpClient 4 from framework modules
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested multiple scenarios with Site-to-Site, secured and non secured, everything seems to be working as expected. Merging, thanks for the refactoring @exceptionfactory !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants