Repository navigation
Allow usage of Java Single File Launcher in non-Java projects - #9666
Conversation
88cdcd1 to
12edabe
Compare
12edabe to
6ce8ced
Compare
|
Glanced through but not tested as yet. Looks good for that, thanks. My original suggestion was whether a file was within a Java SourceGroup. However, that might trigger issues with other project queries (eg. classpath), so what you have makes sense, is safer, and doesn't preclude looking further later if we need to. Have you tested with a Maven parent (POM) project? If it works fine in there, it probably addresses some of the usages that would be nice to support in Java projects anyway. Is the test dependency on SVG really needed? |
| <compile-dependency/> | ||
| </test-dependency> | ||
| <test-dependency> | ||
| <code-name-base>org.openide.util.ui.svg</code-name-base> |
There was a problem hiding this comment.
@neilcsmith-net wrote:
Is the test dependency on SVG really needed?
- No. Good catch.
- the dependency was only needed in
ProjectManager.findProjectOrFallbackAPI #9650 - as the
FallbackProjectthere was using.svgin itsgetIcon - we can remove it from this PR - gone in 7dcaf8e
6ce8ced to
7dcaf8e
Compare
Yes, it seems to work.
No, it is not needed. Removed. |
lahodaj
left a comment
There was a problem hiding this comment.
Looks sensible to me. Minor style comment inline.
7dcaf8e to
ee5d54c
Compare
ProjectManager.findProjectOrFallbackAPI #9650 revealed incorrectness of enablement checkFileOwnerQuery.getOwner(file) == nullthen it disables itself in (for example) C++ projectsIt Works now!