Add Locate in System action to open folder of file.#9246
Open
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
Open
Add Locate in System action to open folder of file.#9246neilcsmith-net wants to merge 1 commit intoapache:masterfrom
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
Conversation
Replace macOS specific Show in Finder action with an action available on all OS to open the parent folder of any file.
neilcsmith-net
added
Code cleanup
Member
|
seems to be similar to #7081, but I believe it did also allow to open folders as tabs in NB, additionally to the system action. |
Member
Author
|
Wish I'd remembered to look again at that before spending time on this one! 😄 However, this is somewhat different in that it is primarily to maintain the existing macOS behaviour without reflection, while providing something similar elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace macOS specific Show in Finder action with an action available on all OS to open the parent folder of any file.
Follow up to conversation in #9245 Should remove unnecessary reflection usage (add-exports not yet removed), and make this action available across all OS as has been requested various times before.
Uses
Desktop::browseFileDirectoryif supported, which selects the file in the file browser.Do not merge pending #9245