nimble/ll: Add vs hci cmd with additional scan cfg #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gorecki
force-pushed
the
vendor-scan-command
branch
2 times, most recently
from
573b0b2 to
41235f8
Compare
sjanc
reviewed
Nov 18, 2024
| return BLE_ERR_INV_HCI_CMD_PARMS; | ||
| } | ||
|
|
||
| if (cmd->flags > BLE_HCI_OCF_VS_SET_SCAN_CFG_NO_EXT) { |
There was a problem hiding this comment.
this should be converted from le32 to host order before check (even if this will be noop on most systems)
it should (at least for now) disallow command if both types are to be disabled
m-gorecki
force-pushed
the
vendor-scan-command
branch
from
41235f8 to
08a817e
Compare
sjanc
approved these changes
Nov 18, 2024
andrzej-kaczmarek
requested changes
Nov 18, 2024
nimble/include/nimble/hci_common.h
Outdated
| @@ -1396,6 +1396,14 @@ struct ble_hci_vs_set_local_irk_cp { | |||
| uint8_t irk[16]; | |||
| } __attribute__((packed)); | |||
|
|
|||
| #define BLE_HCI_OCF_VS_SET_SCAN_CFG_NO_LEGACY 0x00000001 | |||
| #define BLE_HCI_OCF_VS_SET_SCAN_CFG_NO_EXT 0x00000002 | |||
There was a problem hiding this comment.
ble_hci_ocf prefix suggests this is an OCF which is misleading
|
can we also add flag to filter by min rssi on primary channel? |
m-gorecki
force-pushed
the
vendor-scan-command
branch
from
08a817e to
de7b7e6
Compare
m-gorecki
force-pushed
the
vendor-scan-command
branch
from
de7b7e6 to
37e58ee
Compare
sjanc
approved these changes
Nov 19, 2024
This allows to configure scanner to: - ignore either legacy or extended packets, - set minimal RSSI filter on primary channel. If scan is enabled command returns command disallowed error.
m-gorecki
force-pushed
the
vendor-scan-command
branch
from
37e58ee to
660af94
Compare
andrzej-kaczmarek
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to configure scanner to ignore either
legacy or extended packets. If scan is enabled
command returns command disallowed error.