log_fcb: optimize log_fcb_copy #3414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local function log_fcb_copy() did not use information about start location that was already available. Function log_fcb_rtr_erase() found first element to copy and then used only part of what wa returned. In turn log_fcb_copy() walk log again skipping entries. It would not work correctly if more then on sector was used for source fcb and requested number of preserved entries span more then one sector. Signed-off-by: Jerzy Kasenberg <[email protected]>
vrahane
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local function log_fcb_copy() did not use information about start location that was already available.
Function log_fcb_rtr_erase() found first element to copy and then used only part of what wa returned.
In turn log_fcb_copy() walk log again skipping entries.
It would not work correctly if more then on sector was used for source fcb and requested number of
preserved entries span more then one sector.
Code is shorter, faster and uses less stack