Skip to content

Conversation

m-gorecki
Copy link
Contributor

Now -DMBEDTLS_USER_CONFIG_FILE=<mbedtls/config_mynewt.h> flag is used globally for each build that depends on mbedtls package. This way we won't have to add this flag in each package that uses mbedtls.

m-gorecki added a commit to m-gorecki/mcuboot that referenced this pull request Mar 24, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.
m-gorecki added a commit to m-gorecki/mcuboot that referenced this pull request Mar 24, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
@m-gorecki m-gorecki marked this pull request as ready for review March 24, 2025 09:56
@m-gorecki m-gorecki force-pushed the mbedtls-gflag branch 2 times, most recently from 0c75fd7 to f68aeba Compare March 24, 2025 14:38
m-gorecki added a commit to m-gorecki/mcuboot that referenced this pull request Mar 26, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
m-gorecki added a commit to m-gorecki/mcuboot that referenced this pull request Apr 7, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
utzig pushed a commit to mcu-tools/mcuboot that referenced this pull request Apr 8, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
nordic-mik7 pushed a commit to nordic-mik7/sdk-mcuboot that referenced this pull request May 13, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
jasr93 pushed a commit to jasr93/sdk-mcuboot that referenced this pull request May 18, 2025
Now flag defining config file for MbedTLS is global
(see apache/mynewt-core#3394),
so we do not have to include the same flag in bootutil package.
This also enables MBEDTLS_CIPHER_MODE_CTR in boot_serial test
package, as it is used in unit tests and it is disabled by default.

Signed-off-by: Michal Gorecki <[email protected]>
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-gorecki m-gorecki force-pushed the mbedtls-gflag branch 2 times, most recently from 8c194e6 to 8338e55 Compare July 3, 2025 09:08
Now -DMBEDTLS_USER_CONFIG_FILE=<mbedtls/config_mynewt.h> flag is
used globally for each build that depends on mbedtls package.
This way we won't have to add this flag in each package
that uses mbedtls.
@m-gorecki m-gorecki merged commit c0f79fb into apache:master Sep 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants