Conversation
Member
|
see also #249 |
There was a problem hiding this comment.
Pull request overview
This PR updates Javadoc text in AbstractSourceJarMojo to fix typos and adjust wording, improving readability of the plugin’s inline documentation.
Changes:
- Corrected “projet” → “project” in an
@returndescription. - Corrected “addionalExcludes” → “additionalExcludes” in a Javadoc description.
- Adjusted capitalization/punctuation in
@param/@returntext (but introduced some inconsistencies).
Comments suppressed due to low confidence (1)
src/main/java/org/apache/maven/plugins/source/AbstractSourceJarMojo.java:549
- The Javadoc currently says it returns a "list", but the method returns a String array. Also, the @param/@return phrasing is now inconsistent with nearby Javadocs (capitalization / punctuation).
/**
* Combines the user parameter {@link #excludes}, the default excludes from plexus FileUtils, and the contents of
* the parameter additionalExcludes.
*
* @param additionalExcludes additional excludes to add to the array
* @return the combined list of excludes
*/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slachiewicz
approved these changes
Jul 30, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.