Skip to content

Typo fixes - #254

Merged
elharo merged 3 commits into
masterfrom
jd
Jul 30, 2026
Merged

Typo fixes#254
elharo merged 3 commits into
masterfrom
jd

Conversation

@elharo

@elharo elharo commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@slachiewicz

Copy link
Copy Markdown
Member

see also #249

@elharo
elharo marked this pull request as ready for review July 30, 2026 10:53
@elharo
elharo requested review from Copilot and slachiewicz July 30, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Javadoc text in AbstractSourceJarMojo to fix typos and adjust wording, improving readability of the plugin’s inline documentation.

Changes:

  • Corrected “projet” → “project” in an @return description.
  • Corrected “addionalExcludes” → “additionalExcludes” in a Javadoc description.
  • Adjusted capitalization/punctuation in @param/@return text (but introduced some inconsistencies).
Comments suppressed due to low confidence (1)

src/main/java/org/apache/maven/plugins/source/AbstractSourceJarMojo.java:549

  • The Javadoc currently says it returns a "list", but the method returns a String array. Also, the @param/@return phrasing is now inconsistent with nearby Javadocs (capitalization / punctuation).
    /**
     * Combines the user parameter {@link #excludes}, the default excludes from plexus FileUtils, and the contents of
     * the parameter additionalExcludes.
     *
     * @param additionalExcludes additional excludes to add to the array
     * @return the combined list of excludes
     */

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elharo
elharo merged commit 42bbf24 into master Jul 30, 2026
12 checks passed
@elharo
elharo deleted the jd branch July 30, 2026 11:01
@github-actions github-actions Bot added this to the 4.0.0 milestone Jul 30, 2026
@github-actions

Copy link
Copy Markdown

@elharo Please assign appropriate label to PR according to the type of change.

@elharo elharo added the documentation Improvements or additions to documentation label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants