[MRESOURCES-453] Leverage ChangeDetection from maven-filtering #397 by gnodet · Pull Request #527 · apache/maven-resources-plugin

gnodet · 2026-09-25T07:57:09Z

Summary

Port of the ChangeDetection strategy from apache/maven-filtering#397 into the plugin.

Instead of a binary overwrite boolean, expose the new changeDetection enum parameter so users have explicit control over the copy semantics:

Value	Behaviour
`CONTENT`	(default) Only overwrite when content differs — i.e. current post-3.4.0 behaviour via `CachingOutputStream`
`TIMESTAMP`	Only overwrite when source is newer than destination — i.e. pre-3.4.0 behaviour
`TIMESTAMP_AND_CONTENT`	Combine both checks
`ALWAYS`	Always overwrite (replaces `<overwrite>true</overwrite>`)
`NEVER`	Never overwrite an existing destination file

Changes

pom.xml: bump mavenFilteringVersion to 4.0.0-beta-2-SNAPSHOT (requires feat: introduce ChangeDetection strategy for file copy maven-filtering#397 to be merged and released first)
ResourcesMojo: add changeDetection @Parameter (default CONTENT); deprecate overwrite with backward-compat bridge (overwrite=true → ALWAYS; overwrite=false defers to the declared changeDetection)
New IT MRESOURCES-453: verifies changeDetection=NEVER leaves an existing destination file untouched even when source content differs

Fixes

Destination file overwritten even with overwrite false in 3.4.0 #453 (destination overwritten even with overwrite=false in 3.4.0)
[MRESOURCES-278] Regression - Changed copy behaviour if file already exists #354 (TIMESTAMP strategy restores pre-3.4.0 semantics)

The root cause is in maven-filtering (the overwrite parameter was silently dropped when the NIO/CachingOutputStream migration landed). This PR is the plugin-side companion to apache/maven-filtering#397.

[MRESOURCES-313] Debug says 'copy' but does not do that when overwrite = false #316 — misleading "Copying file" debug log when file is skipped by change-detection. Fixed upstream in feat: introduce ChangeDetection strategy for file copy maven-filtering#397 (log is now emitted after the copy, "Copying file X" when written, "Skipping file X (up to date)" when skipped). The fix lands once this PR bumps mavenFilteringVersion to the released 4.0.0-beta-2.
[MRESOURCES-274] set overwrite per resource #286 (per-resource changeDetection, separate feature — supported via Resource.changeDetection in maven-filtering#397)

@parameter

Replace the deprecated boolean 'overwrite' parameter with a 'changeDetection' strategy enum (CONTENT / TIMESTAMP / TIMESTAMP_AND_CONTENT / ALWAYS / NEVER), forwarded from maven-filtering 4.0.0-beta-2-SNAPSHOT (PR apache/maven-filtering#397). - Add 'changeDetection' @parameter (default CONTENT, i.e. current behaviour) - Deprecate 'overwrite'; bridge: overwrite=true maps to ALWAYS, overwrite=false keeps the declared changeDetection value (backward-compat) - Add IT MRESOURCES-453: verifies that changeDetection=NEVER leaves an existing destination file untouched even when source content differs Fixes: #453 Depends on: apache/maven-filtering#397

gnodet-bot

Clean and well-structured change. The backward-compat bridge (overwrite=true → ALWAYS) is correct, the Javadoc is thorough, and the IT covers the NEVER edge case properly with setup/verify scripts.

One minor documentation nit below.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

gnodet-bot · 2026-09-25T08:02:10Z

+     *   <li>{@code NEVER} — never overwrite an existing destination file.</li>
+     * </ul>
+     *
+     * @since 3.4.0


💡 @since 3.4.0 is wrong — this parameter is introduced in this PR, and the project version is 4.0.0-beta-2-SNAPSHOT. The @since should reflect the actual release version.

Suggested change

* @since 3.4.0

* @since 4.0.0-beta-2

Fixed in 83ca419.

gnodet-bot

Re-review after new commit 476787e (CI: enable Apache Snapshots repo for SNAPSHOT dependency). The CI change is correct — needed for the maven-filtering 4.0.0-beta-2-SNAPSHOT dependency.

However, the @since finding from the previous review is still unaddressed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

gnodet-bot · 2026-09-25T10:04:18Z

+     *   <li>{@code NEVER} — never overwrite an existing destination file.</li>
+     * </ul>
+     *
+     * @since 3.4.0


⚠️ Still unresolved from previous review: @since 3.4.0 is incorrect — this parameter is introduced in this PR. The project version is 4.0.0-beta-2-SNAPSHOT, so this should be @since 4.0.0-beta-2.

Suggested change

* @since 3.4.0

* @since 4.0.0-beta-2

Fixed in 83ca419.

gnodet · 2026-09-25T10:07:33Z

CI failure: ChangeDetection class not found in maven-filtering 4.0.0-beta-2-SNAPSHOT.

The prerequisite PR apache/maven-filtering#397 (which introduces the ChangeDetection enum) has not been merged yet. The current SNAPSHOT deployed to Apache Snapshots (build -100, Sep 24) does not contain this class.

This PR cannot compile until maven-filtering#397 is merged and a new SNAPSHOT is deployed.

gnodet-bot

Re-review after commit 476787e (CI: add -Dapache.snapshots for SNAPSHOT dependency). CI change is correct and necessary.

The @since finding from both previous reviews remains unaddressed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

gnodet-bot · 2026-09-25T10:07:37Z

+     *   <li>{@code NEVER} — never overwrite an existing destination file.</li>
+     * </ul>
+     *
+     * @since 3.4.0


⚠️ Still unresolved (3rd review): @since 3.4.0 is incorrect — the changeDetection parameter is introduced in this PR. The milestone is 4.0.0-beta-2.

Suggested change

* @since 3.4.0

* @since 4.0.0-beta-2

Fixed in 83ca419.

gnodet · 2026-09-25T11:00:57Z

CI failure on 4.0.0-rc-7: ChangeDetection class not found in org.apache.maven.shared.filtering.

This is expected — this PR depends on apache/maven-filtering#397 being merged and deployed as a SNAPSHOT first. That PR is open with CI green, awaiting review/merge.

Once maven-filtering#397 is merged and the SNAPSHOT is published, CI here will pass.

gnodet-bot

Re-review after commit 83ca419 — the @since tag is now correctly set to 4.0.0-beta-2. Previous finding addressed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

gnodet · 2026-09-25T11:07:38Z

⚠️ CI blocked on upstream dependency

The compilation fails because ChangeDetection class does not exist in the current maven-filtering 4.0.0-beta-2-SNAPSHOT. This class is introduced by apache/maven-filtering#397, which is still open (CI is green, awaiting merge).

Once maven-filtering#397 is merged and the snapshot is deployed, this PR's CI should pass.

— Hermès 🤖

gnodet-bot reviewed Sep 25, 2026

View reviewed changes

gnodet mentioned this pull request Sep 25, 2026

[MRESOURCES-274] set overwrite per resource #286

Open

ci: enable Apache Snapshots repo for maven-filtering SNAPSHOT dependency

476787e

gnodet-bot reviewed Sep 25, 2026

View reviewed changes

fix: correct @SInCE tag to 4.0.0-beta-2 for changeDetection parameter

83ca419

gnodet-bot approved these changes Sep 25, 2026

View reviewed changes

This was referenced Sep 25, 2026

feat: introduce ChangeDetection strategy for file copy apache/maven-filtering#397

Open

[MRESOURCES-313] Debug says 'copy' but does not do that when overwrite = false #316

Open

Navigation Menu

[MRESOURCES-453] Leverage ChangeDetection from maven-filtering #397 - #527

[MRESOURCES-453] Leverage ChangeDetection from maven-filtering #397#527
gnodet wants to merge 3 commits into
masterfrom
fix/change-detection

gnodet commented Sep 25, 2026 •

edited

Loading

Uh oh!

gnodet-bot left a comment

Uh oh!

gnodet-bot Sep 25, 2026

Uh oh!

gnodet Sep 25, 2026

Uh oh!

gnodet-bot left a comment

Uh oh!

gnodet-bot Sep 25, 2026

Uh oh!

gnodet Sep 25, 2026

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

gnodet-bot left a comment

Uh oh!

gnodet-bot Sep 25, 2026

Uh oh!

gnodet Sep 25, 2026

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

gnodet-bot left a comment

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gnodet commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Fixes

Related

Uh oh!

gnodet-bot left a comment

Choose a reason for hiding this comment

Uh oh!

gnodet-bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet-bot left a comment

Choose a reason for hiding this comment

Uh oh!

gnodet-bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

gnodet-bot left a comment

Choose a reason for hiding this comment

Uh oh!

gnodet-bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

gnodet-bot left a comment

Choose a reason for hiding this comment

Uh oh!

gnodet commented Sep 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gnodet commented Sep 25, 2026 •

edited

Loading