[MRESOURCES-232] Resource copy filtering should use different encoding for source and output

[jira-importer]

Peng Cheng opened MRESOURCES-232 and commented

In copy-resources goal. The configuration option 'encoding' is documented to be capable of changing the encoding of source files and copy to output directory, e.g.:

<configuration>
    <outputDirectory>${project.basedir}/sbin-ebcdic</outputDirectory>
    <resources>
        <resource>
            <directory>${project.basedir}/sbin</directory>
        </resource>
    </resources>
    <encoding>IBM037</encoding>
</configuration>

However, it is pointed out in the answer section of this post:

http://stackoverflow.com/questions/40095716/why-maven-resources-plugin-ignores-my-charset-encoding-setting

that this option affects both reading of source file and writing of output file, resulting in most of the file encodings not converted. This should be corrected by dividing this option into 2:

sourceEncoding & outputEncoding, which controls reading and writing separately. This is the most simple way to make encoding conversion practical.

---

Affects: 3.0.1

0 votes, 6 watchers

[jira-importer]

Elliotte Rusty Harold commented

agreed

[jira-importer]

Dennis Lundberg commented

Could you please add a reference to where in the documentation it states that encoding can be changed during filtering, so that we can correct that. With the current implementation that is not possible.

Do you have a use case where you want the source-resources to be one encoding and the target-resources be another encoding?

[jira-importer]

Dennis Lundberg commented

I have updated the documentation for the "encoding" parameter to clarify that it is used for both reading and writing resources. That will come with version 3.2.0 of the plugin.

The need for different input and output encoding parameters have not yet been solved.

[jira-importer]

Delany commented

Would also be handy to set a verbosity level on the logging. I'd like to turn off all of these

[INFO] Using 'UTF-8' encoding to copy filtered resources. 
[INFO] Using 'UTF-8' encoding to copy filtered properties files.

[gnodet]

This is now being addressed in apache/maven-filtering#406, which consolidates the separate input/output encoding support (MRESOURCES-232) with per-resource encoding overrides (MRESOURCES-281) into a single squashed PR on top of the ChangeDetection work (apache/maven-filtering#397). The earlier draft PR #407 has been closed in favour of #406.