Skip to content

Bump mavenVersion from 4.0.0-rc-3 to 4.0.0-rc-4 #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Bump mavenVersion from 4.0.0-rc-3 to 4.0.0-rc-4 #607

wants to merge 5 commits into from
+14 −6

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 25, 2025 •
edited
Loading

Bumps mavenVersion from 4.0.0-rc-3 to 4.0.0-rc-4.
Updates org.apache.maven:maven-api-core from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-api-core's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

... (truncated)

Commits
  • bed0f81 [maven-release-plugin] prepare release maven-4.0.0-rc-4
  • ddc228e Unfurl CLI (#2465)
  • bcf9838 [MNG-8765] Maven Upgrade Tool (#2407)
  • 5000b59 Maven4 "legacy" mode and more (#2380)
  • b61b3bd Add missing @​Override to overriding and implementing methods (#2402)
  • d03b61d [MNG-8713] SourceRoot.directory() default value should include the module whe...
  • bede125 [MNG-8731] Use https for xsi:schemaLocation in generated descriptors
  • 75b6c11 [MNG-8686] Add SourceRoot.matcher(boolean) method (#2236)
  • 972f26d [MNG-8719] Restore Maven3 compat: model setInherited(boolean) (#2288)
  • d65c375 [MNG-8712] dependency version is a requirement, not effective
  • Additional commits viewable in compare view

Updates org.apache.maven:maven-api-di from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-api-di's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

... (truncated)

Commits
  • bed0f81 [maven-release-plugin] prepare release maven-4.0.0-rc-4
  • ddc228e Unfurl CLI (#2465)
  • bcf9838 [MNG-8765] Maven Upgrade Tool (#2407)
  • 5000b59 Maven4 "legacy" mode and more (#2380)
  • b61b3bd Add missing @​Override to overriding and implementing methods (#2402)
  • d03b61d [MNG-8713] SourceRoot.directory() default value should include the module whe...
  • bede125 [MNG-8731] Use https for xsi:schemaLocation in generated descriptors
  • 75b6c11 [MNG-8686] Add SourceRoot.matcher(boolean) method (#2236)
  • 972f26d [MNG-8719] Restore Maven3 compat: model setInherited(boolean) (#2288)
  • d65c375 [MNG-8712] dependency version is a requirement, not effective
  • Additional commits viewable in compare view

Updates org.apache.maven:maven-api-annotations from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-api-annotations's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

... (truncated)

Commits
  • bed0f81 [maven-release-plugin] prepare release maven-4.0.0-rc-4
  • ddc228e Unfurl CLI (#2465)
  • bcf9838 [MNG-8765] Maven Upgrade Tool (#2407)
  • 5000b59 Maven4 "legacy" mode and more (#2380)
  • b61b3bd Add missing @​Override to overriding and implementing methods (#2402)
  • d03b61d [MNG-8713] SourceRoot.directory() default value should include the module whe...
  • bede125 [MNG-8731] Use https for xsi:schemaLocation in generated descriptors
  • 75b6c11 [MNG-8686] Add SourceRoot.matcher(boolean) method (#2236)
  • 972f26d [MNG-8719] Restore Maven3 compat: model setInherited(boolean) (#2288)
  • d65c375 [MNG-8712] dependency version is a requirement, not effective
  • Additional commits viewable in compare view

Updates org.apache.maven:maven-api-model from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-api-model's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

... (truncated)

Commits
  • bed0f81 [maven-release-plugin] prepare release maven-4.0.0-rc-4
  • ddc228e Unfurl CLI (#2465)
  • bcf9838 [MNG-8765] Maven Upgrade Tool (#2407)
  • 5000b59 Maven4 "legacy" mode and more (#2380)
  • b61b3bd Add missing @​Override to overriding and implementing methods (#2402)
  • d03b61d [MNG-8713] SourceRoot.directory() default value should include the module whe...
  • bede125 [MNG-8731] Use https for xsi:schemaLocation in generated descriptors
  • 75b6c11 [MNG-8686] Add SourceRoot.matcher(boolean) method (#2236)
  • 972f26d [MNG-8719] Restore Maven3 compat: model setInherited(boolean) (#2288)
  • d65c375 [MNG-8712] dependency version is a requirement, not effective
  • Additional commits viewable in compare view

Updates org.apache.maven:maven-core from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-core's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

... (truncated)

Commits

Updates org.apache.maven:maven-impl from 4.0.0-rc-3 to 4.0.0-rc-4

Release notes

Sourced from org.apache.maven:maven-impl's releases.

4.0.0-rc-4

🚀 New features and improvements

🐛 Bug Fixes

📝 Documentation updates

👻 Maintenance

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 25, 2025
@dependabot dependabot bot force-pushed the dependabot/maven/mavenVersion-4.0.0-rc-4 branch from 5e81b7a to 4c48c2b Compare August 8, 2025 13:10
@slachiewicz slachiewicz force-pushed the dependabot/maven/mavenVersion-4.0.0-rc-4 branch from 26b0d54 to 4260852 Compare August 8, 2025 20:10
@slachiewicz
Copy link
Member

/Users/xx/apache-maven-4.0.0-rc-4/bin/mvn: line 265: url=file://${project.basedir}/target/repo: bad substitution Running post-build script: /Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging/verify.bsh target file is missing or not a directory. Finished post-build script: /Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging/verify.bsh

@slachiewicz slachiewicz force-pushed the dependabot/maven/mavenVersion-4.0.0-rc-4 branch from 1023adc to 8345c72 Compare August 10, 2025 10:46
@slachiewicz
Copy link
Member

About to execute:
"/opt/homebrew/opt/openjdk/bin/java" --enable-native-access=ALL-UNNAMED -classpath "/Users/xx/apache-maven-4.0.0-rc-4/boot/plexus-classworlds-2.9.0.jar" "-Dclassworlds.conf=/Users/xx/apache-maven-4.0.0-rc-4/bin/m2.conf" "-Dmaven.home=/Users/xx/apache-maven-4.0.0-rc-4" "-Dmaven.mainClass=org.apache.maven.cling.MavenCling" "-Dlibrary.jline.path=/Users/xx/apache-maven-4.0.0-rc-4/lib/jline-native" "-Dmaven.multiModuleProjectDirectory=/Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging" org.codehaus.plexus.classworlds.launcher.Launcher "-B" "-X" "-D" "maven.repo.local=/Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/local-repo" "-s" "/Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/interpolated-settings.xml" "-D" "maven.compiler.source=17" "-D" "groupId=org.apache.maven.test" "-D" "version=1.1" "-D" "url=file://${project.basedir}/target/repo" "-D" "maven.compiler.target=17" "-D" "file=${project.basedir}/lib/test-1.1.jar" "-D" "artifactId=test" "org.apache.maven.plugins:maven-deploy-plugin:4.0.0-beta-3-SNAPSHOT:deploy-file"
/Users/xx/apache-maven-4.0.0-rc-4/bin/mvn: line 265: url=file://${project.basedir}/target/repo: bad substitution

@slachiewicz
Copy link
Member

not sure if it's Maven 4 rc4 problem or something on m-invoker-pugin and it was working before by chance
@slawekjaranowski @gnodet

@slawekjaranowski
Copy link
Member

not sure if it's Maven 4 rc4 problem or something on m-invoker-pugin and it was working before by chance @slawekjaranowski @gnodet

can be something like in .... apache/maven#10970 but with user properties ....

by the way invoker should not execute post script if process return error code

@slachiewicz
Copy link
Member

Not spotted before, nothing from test.properries is interpolated by m-invoker-plugin.
I'll try to check how it was working with rc3 at runtime. And to see how it works with mvn3

@slachiewicz
Copy link
Member

works with rc3. Looks like it may be related to changes here apache/maven#2213

with rc3 bellow command is executed and it works:
/opt/homebrew/opt/openjdk/bin/java --enable-native-access=ALL-UNNAMED -classpath /Users/xx/apache-maven-4.0.0-rc-3/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/Users/xx/apache-maven-4.0.0-rc-3/bin/m2.conf -Dmaven.home=/Users/xx/apache-maven-4.0.0-rc-3 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/Users/xx/apache-maven-4.0.0-rc-3/lib/jline-native -Dmaven.multiModuleProjectDirectory=/Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging org.codehaus.plexus.classworlds.launcher.Launcher -B -X -D maven.repo.local=/Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/local-repo -s /Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/interpolated-settings.xml -D maven.compiler.source=17 -D groupId=org.apache.maven.test -D version=1.1 -D url=file://${project.basedir}/target/repo -D maven.compiler.target=17 -D file=${project.basedir}/lib/test-1.1.jar -D artifactId=test org.apache.maven.plugins:maven-deploy-plugin:4.0.0-beta-3-SNAPSHOT:deploy-file

then mojo is configured:
[DEBUG] Configuring mojo execution 'org.apache.maven.plugins:maven-deploy-plugin:4.0.0-beta-3-SNAPSHOT:deploy-file:default-cli' with enhanced configurator -->
[DEBUG] (f) artifactId = test
[DEBUG] (f) file = /Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging/lib/test-1.1.jar
[DEBUG] (f) generatePom = true
[DEBUG] (f) groupId = org.apache.maven.test
[DEBUG] (f) offline = false
[DEBUG] (f) repositoryId = remote-repository
[DEBUG] (f) retryFailedDeploymentCount = 1
[DEBUG] (f) skip = false
[DEBUG] (f) url = file:///Users/xx/mvn4/plugins/core/maven-deploy-plugin/target/it/deploy-default-packaging/target/repo
[DEBUG] (f) version = 1.1
[DEBUG] -- end configuration --

dependabot bot and others added 5 commits August 10, 2025 21:01
@dependabot @slachiewicz
Bump mavenVersion from 4.0.0-rc-3 to 4.0.0-rc-4
cfd0f7d 
Bumps `mavenVersion` from 4.0.0-rc-3 to 4.0.0-rc-4.

Updates `org.apache.maven:maven-api-core` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

Updates `org.apache.maven:maven-api-di` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

Updates `org.apache.maven:maven-api-annotations` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

Updates `org.apache.maven:maven-api-model` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

Updates `org.apache.maven:maven-core` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

Updates `org.apache.maven:maven-impl` from 4.0.0-rc-3 to 4.0.0-rc-4
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-4.0.0-rc-3...maven-4.0.0-rc-4)

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-api-core
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-api-di
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-api-annotations
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-api-model
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-core
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-impl
  dependency-version: 4.0.0-rc-4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@slachiewicz
fix api
65e88ee
@slachiewicz
fix something and use newer plugin
f4d1fc0
@slachiewicz
issue?
216c89f
@slachiewicz
Use default rc-4
d7b3d7a
@slachiewicz slachiewicz force-pushed the dependabot/maven/mavenVersion-4.0.0-rc-4 branch from 8345c72 to d7b3d7a Compare August 10, 2025 19:06
@slachiewicz slachiewicz marked this pull request as draft August 10, 2025 19:06
@slawekjaranowski
Copy link
Member

works with rc3. Looks like it may be related to changes here apache/maven#2213

so look like user properties on cli can not contains an property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slachiewicz @slawekjaranowski