[MCOMPILER-397] Use relative paths in jpms.args to make the builds reproducible #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is incomplete, the path separators have to be normalized too. |
slawekjaranowski
added
the
waiting-for-feedback
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Mar 15, 2025
|
Done on a clone of the master branch (not yet merged). The fix in this pull request could not be applied on master, but could be applied on the 3.x branch. Should we redirect the target branch to 3.x, or close as "fixed" (after merge of aa4509b)? |
github-actions
bot
removed
the
waiting-for-feedback
|
We can change target branch by edit PR ... |
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Mar 24, 2025
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Mar 26, 2025
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Apr 2, 2025
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Apr 2, 2025
desruisseaux
added a commit
to Geomatys/maven-compiler-plugin
that referenced
this pull request
Apr 6, 2025
|
ok, was merged with #320 - one big PR 😄 |
|
Resolve #626 |
slawekjaranowski
added
the
waiting-for-feedback
|
This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://issues.apache.org/jira/browse/MCOMPILER-397