Consider default excludes when choosing files to check #653
+11
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks more like bug |
elharo
commented
Jan 7, 2026
| private List<File> getFilesToProcess(CheckstyleExecutorRequest request) throws IOException { | ||
| StringBuilder excludesStr = new StringBuilder(); | ||
|
|
||
| if (StringUtils.isNotEmpty(request.getExcludes())) { |
Contributor
Author
There was a problem hiding this comment.
addFilesToProcess gets the excludes from the request, but it does not currently get the default excludes. That's the difference.
elharo
changed the title
elharo
commented
Jan 14, 2026
Contributor
Author
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
PTAL
Now actually considers the excludes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The excludes are not used here. Consider if they should be removed like this PR or somehow used.