Skip to content

Conversation

thecoop
Copy link
Contributor

@thecoop thecoop commented Jun 30, 2025

Following from the regression identified in #14705 (comment), use LessThan rather than Comparator (which involves less function calls) for these key queues

Copy link
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@thecoop
Copy link
Contributor Author

thecoop commented Jun 30, 2025

It is unclear which luceneutil commands the two performance tests can be run with, so I haven't been able to verify this fixed the performance drop locally.

@thecoop thecoop requested review from dweiss and jpountz June 30, 2025 09:25
@jpountz
Copy link
Contributor

jpountz commented Jun 30, 2025

You need to add the nightly tasks which had a slowdown to your tasks file, e.g. here are the CountOrMany tasks: https://github.com/mikemccand/luceneutil/blob/main/tasks/wikinightly.tasks#L305-L309. Nightly benchmarks run with the wikibigall collection, but wikimedium10m or wikimediumall should be good too in order to confirm that performance gets better.

@thecoop
Copy link
Contributor Author

thecoop commented Jul 1, 2025

This shows some improvement in those two tests - I say merge it and see what this and #14873 does

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me.

@thecoop thecoop merged commit cd27603 into apache:main Jul 1, 2025
8 checks passed
@thecoop thecoop deleted the priority-queue-lessthan branch July 1, 2025 13:54
@thecoop
Copy link
Contributor Author

thecoop commented Jul 2, 2025

Looks like this has improved performance back to what it was - https://benchmarks.mikemccandless.com/2025.07.01.18.04.59.html

@jpountz
Copy link
Contributor

jpountz commented Jul 5, 2025

Thank you! I pushed an annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants