Fix acceptOrds in EmptyOffHeapVectorValues to match no bits #14119
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyOffHeapVectorValues currently returns null for
getAcceptOrds()
. However, internally across the codebase, we assume that nullBits
imply that all values are accepted – like null foracceptDocs()
or live docs.Since EmptyOffHeapVectorValues have not vectors, they should really reject all ordinals.
This doesn't have much impact because I don't see much usage of Empty VectorValues. But it's good to clean up and keep assumptions consistent.