Removing unnecessary ByteArrayDataInput allocations by resetting inplace #14113
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Jain <[email protected]>
iverase
reviewed
Jan 8, 2025
| @@ -1324,8 +1324,12 @@ private void decompressBlock() throws IOException { | |||
| } | |||
|
|
|||
| // Reset the buffer. | |||
| blockInput = | |||
| new ByteArrayDataInput(blockBuffer.bytes, blockBuffer.offset, blockBuffer.length); | |||
| if (blockInput == null) { | |||
There was a problem hiding this comment.
I wonder if we should create the blockInput on the constructor and make it final.
Signed-off-by: Ankit Jain <[email protected]>
iverase
reviewed
Jan 8, 2025
| @@ -1149,6 +1148,8 @@ private class TermsDict extends BaseTermsEnum { | |||
| // add 7 padding bytes can help decompression run faster. | |||
| int bufferSize = entry.maxBlockLength + entry.maxTermLength + LZ4_DECOMPRESSOR_PADDING; | |||
| blockBuffer = new BytesRef(new byte[bufferSize], 0, bufferSize); | |||
| blockInput = | |||
| new ByteArrayDataInput(blockBuffer.bytes, blockBuffer.offset, blockBuffer.length); | |||
There was a problem hiding this comment.
nit: you can initialize it without arguments.
Signed-off-by: Ankit Jain <[email protected]>
|
Could you add an entry in CHANGES.txt under the lucene 10.2 section? |
Signed-off-by: Ankit Jain <[email protected]>
iverase
pushed a commit
that referenced
this pull request
Jan 10, 2025
…ace (#14113) Removing unnecessary ByteArrayDataInput allocations by resetting inplace Signed-off-by: Ankit Jain <[email protected]>
|
Thank you @jainankitk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #14112