Fix createOnDemand for Rolling File Appender

[ramanathan1504]

Fixes #2006

PR Notes: RollingFile createOnDemand validation

Scope

• Module tested: spring-boot-test only
• core-java-test and log4j2-web-test left unchanged

What was run

• Local dependency check confirmed 2.26.0-SNAPSHOT artifacts resolved from ~/.m2
• Startup timing probes from SpringBootTestApp#printLogPathState used as source of truth

Results (2.26.0-SNAPSHOT)

createOnDemand="true" (default log4j2.xml)

• main-entry: dir=false app.log=false app-json.log=false
• after LogManager.getLogger: dir=false app.log=false app-json.log=false
• after first log event: dir=true app.log=true app-json.log=true

Conclusion: directory and files are created on first log event (expected on-demand behavior).

createOnDemand="false" (log4j2-createOnDemand-false.xml)

• main-entry: dir=false app.log=false app-json.log=false
• after LogManager.getLogger: dir=true app.log=true app-json.log=true
• after first log event: dir=true app.log=true app-json.log=true

Conclusion: eager creation occurs before first log event (expected non-demand behavior).

[vy]

Checked with @ppkarwasz, the fix looks good. Could you also add a changelog entry (referencing to both the Issue and PR IDs), please?

[vy]

@ramanathan1504, if you can get this merged until next week, I can ship it with 2.26.0.

[ramanathan1504]

@ramanathan1504, if you can get this merged until next week, I can ship it with 2.26.0.
@vy within a day i will complete👍

[vy]

@ramanathan1504, please do NOT force-push. It truncates the entire conversation history and I cannot see what incremental changes you've pushed. That is, I need to re-review everything from scratch.

[ramanathan1504]

@ramanathan1504, please do NOT force-push. It truncates the entire conversation history and I cannot see what incremental changes you've pushed. That is, I need to re-review everything from scratch.

@vy Thanks for the clarification. I will avoid force-pushing and will push incremental commits.