Repository navigation
test(replication): wait for the first fetched file instead of a fixed sleep - #3800
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestReplicationWithLimitSpeedwaited a fixed 5 seconds for the slave to receive "some" SST files before restarting the master. How many files arrive in 5 seconds depends on the machine, and the test only needs the slave to have fetched one file for the resume-and-skip assertion. Waiting for the actual condition removes the fixed delay.Changes
[fetch] Fetchedline, then restart the master as before.Testing
go test ./integration/replicationlocally: 46.55s before, 35.92s after.TestReplicationWithLimitSpeed: 31.38s before, 24.75s after.go test ./integration/replication -count=3 -run TestReplicationWithLimitSpeedto check the condition wait is not flaky.Part of #3527