-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of the CLUSTER REPLICAS command #2244
Merged
git-hulk
merged 7 commits into
apache:unstable
from
proost:feat-cluster-replicas-command
Apr 13, 2024
Merged
Add support of the CLUSTER REPLICAS command #2244
git-hulk
merged 7 commits into
apache:unstable
from
proost:feat-cluster-replicas-command
Apr 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-cluster-replicas-command
git-hulk
reviewed
Apr 13, 2024
Generally LGTM, only one comment is inline. |
caipengbo
previously approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PragmaTwice
reviewed
Apr 13, 2024
PragmaTwice
reviewed
Apr 13, 2024
…t-cluster-replicas-command
PragmaTwice
previously approved these changes
Apr 13, 2024
PragmaTwice
approved these changes
Apr 13, 2024
caipengbo
approved these changes
Apr 13, 2024
git-hulk
approved these changes
Apr 13, 2024
git-hulk
changed the title
feat: support cluster replicas command
Add support of the CLUSTER REPLICAS command
Apr 13, 2024
@proost Thanks for your contribution. |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: 1942
Add
CLUSTER REPLICAS
command