Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of the CLUSTER REPLICAS command #2244

Merged
merged 7 commits into from
Apr 13, 2024

Conversation

proost
Copy link
Contributor

@proost proost commented Apr 12, 2024

close: 1942

Add CLUSTER REPLICAS command

src/cluster/cluster.cc Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

Generally LGTM, only one comment is inline.

@git-hulk git-hulk added the feature type new feature label Apr 13, 2024
caipengbo
caipengbo previously approved these changes Apr 13, 2024
Copy link
Contributor

@caipengbo caipengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cluster/cluster.cc Outdated Show resolved Hide resolved
src/cluster/cluster.cc Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice previously approved these changes Apr 13, 2024
@git-hulk git-hulk changed the title feat: support cluster replicas command Add support of the CLUSTER REPLICAS command Apr 13, 2024
@git-hulk git-hulk merged commit 6aabd80 into apache:unstable Apr 13, 2024
30 checks passed
@git-hulk
Copy link
Member

@proost Thanks for your contribution.

Copy link

@proost proost deleted the feat-cluster-replicas-command branch April 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature type new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Towards a more redis-compatible database
4 participants