Skip to content

Conversation

@TaiJuWu
Copy link
Collaborator

@TaiJuWu TaiJuWu commented Nov 4, 2025

Add missing log4j2.yaml file for some modules.

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) KIP-932 Queues for Kafka transactions Transactions and EOS labels Nov 4, 2025
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@github-actions github-actions bot removed the triage PRs from the community label Nov 5, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since modules like coordinator-comon lack this configuration, perhaps you should check them to ensure consistency

@m1a2st
Copy link
Collaborator

m1a2st commented Nov 5, 2025

Since modules like coordinator-comon lack this configuration, perhaps you should check them to ensure consistency

But this change is in the test resources directory, so I think there’s no consistency issue, right?

@TaiJuWu
Copy link
Collaborator Author

TaiJuWu commented Nov 5, 2025

Since modules like coordinator-comon lack this configuration, perhaps you should check them to ensure consistency

Actually, I am not sure why there is no such configuration and I have no idea how to change the logger level in these module so I think we can add it.

@chia7712
Copy link
Member

chia7712 commented Nov 5, 2025

My point was - should we add the configuration to all modules having test code?

@github-actions github-actions bot added tools connect storage Pull requests that target the storage module group-coordinator labels Nov 5, 2025
This reverts commit 07a2fb3.
@TaiJuWu
Copy link
Collaborator Author

TaiJuWu commented Nov 5, 2025

My point was - should we add the configuration to all modules having test code?

Yes, we should but I am not familiar with developing connector and streams so I prefer to keep them at this state.

@TaiJuWu TaiJuWu removed the connect label Nov 5, 2025
@chia7712
Copy link
Member

@TaiJuWu could you rebase code to include the recent fix for the flaky?

@TaiJuWu TaiJuWu changed the title MINOR: Add missing log4j2.yaml file for server, shareCoordinator, transaction-coordinator MINOR: Add missing log4j2.yaml file for some module Nov 11, 2025
@TaiJuWu TaiJuWu changed the title MINOR: Add missing log4j2.yaml file for some module MINOR: Add missing log4j2.yaml file for some test module Nov 11, 2025
@TaiJuWu TaiJuWu changed the title MINOR: Add missing log4j2.yaml file for some test module MINOR: Add missing log4j2.yaml file for some modules Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker group-coordinator KIP-932 Queues for Kafka storage Pull requests that target the storage module tests Test fixes (including flaky tests) tools transactions Transactions and EOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants