-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: Add missing log4j2.yaml file for some modules #20821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
m1a2st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
chia7712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since modules like coordinator-comon lack this configuration, perhaps you should check them to ensure consistency
But this change is in the test resources directory, so I think there’s no consistency issue, right? |
Actually, I am not sure why there is no such configuration and I have no idea how to change the logger level in these module so I think we can add it. |
|
My point was - should we add the configuration to all modules having test code? |
This reverts commit 07a2fb3.
Yes, we should but I am not familiar with developing connector and streams so I prefer to keep them at this state. |
|
@TaiJuWu could you rebase code to include the recent fix for the flaky? |
Add missing log4j2.yaml file for some modules.