KAFKA-19734 Adding application tag to clientstate metric #20766
Conversation
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the PR @gensericghiro! Can you update/add a test to StreamsMetricsImplTest otherwise lgtm
mjsax
added
kip
|
Merged #20766 into trunk |
|
@gensericghiro let's do the documentation in a follow-up PR |
| final Map<String, String> tagMap = new LinkedHashMap<>(); | ||
| tagMap.put(CLIENT_ID_TAG, clientId); | ||
| tagMap.put(PROCESS_ID_TAG, processId); | ||
| tagMap.put(APPLICATION_ID_TAG, applicationId); |
There was a problem hiding this comment.
Pardon me. I see this new tag applied al all metrics, yet the KIP only specifies the client-state metric. Am I misunderstanding the scope? thanks!
There was a problem hiding this comment.
You're right, good catch. It doesn't seem like I can add a tag for a specific metric however. Since addClientStateTelemetryMetric is calling the generic addClientLevelMutableMetric method, where tags get added, we'd need to add conditional logic there, which I don't think is something we want.
There was a problem hiding this comment.
@chia7712 - thanks for pointing this out. I'm going to start a discussion on the mailing list with a couple of options on how to address the situation.
There was a problem hiding this comment.
As discussed on the mailing list, we are cleaning this up. Cf #20883
## Summary As a follow-on to the improvements introduced in [KIP-1091](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics) it would be useful to add the application-id as a tag to the `client-state` metric. This allows Kafka Streams developers and operators to connect metrics containing a `thread-id` (which embeds the `application-id`) across separate deployments of Kafka Streams instances, which are members of the same logical application. Reviewers: Bill Bejeck<[email protected]> Matthias Sax<[email protected]>
4 participants
Summary
As a follow-on to the improvements introduced in
KIP-1091
it would be useful to add the application-id as a tag to the
client-statemetric. This allows Kafka Streams developers andoperators to connect metrics containing a
thread-id(which embeds theapplication-id) across separate deployments of Kafka Streamsinstances, which are members of the same logical application.
Reviewers: Bill Bejeck[email protected] Matthias
Sax[email protected]