Skip to content

MINOR: Split gradle root config into dedicated sections #20259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MINOR: Split gradle root config into dedicated sections #20259

wants to merge 1 commit into from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Jul 30, 2025 •
edited by github-actions bot
Loading

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions labels Jul 30, 2025
Pankraz76
Pankraz76 commented Jul 30, 2025
View reviewed changes
Pankraz76
Pankraz76 commented Jul 30, 2025
View reviewed changes
@Pankraz76
Copy link
Author

Pankraz76 commented Jul 30, 2025 •
edited
Loading

@ravikalla
@m1a2st

is this dedication/extraction any good?

Please could you help me moving the remaining config? Its not working inside the spotbugs file.

Thanks.

Pankraz76
Pankraz76 commented Jul 30, 2025
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the extract-qa branch 2 times, most recently from bb567b2 to bf85b16 Compare July 30, 2025 11:03
@github-actions github-actions bot removed the triage PRs from the community label Jul 31, 2025
@Pankraz76
Copy link
Author

thanks for approval will fix ci.

@Pankraz76 Pankraz76 marked this pull request as ready for review July 31, 2025 08:02
@Pankraz76 Pankraz76 changed the title MINOR: Separate gradle config of QA plugins MINOR: Split gradle plugin config of quality gates (spotless, spotbugs, and checkstyle) into dedicated files Jul 31, 2025
@Pankraz76 Pankraz76 force-pushed the extract-qa branch 3 times, most recently from 33c252a to df4c9ef Compare July 31, 2025 08:33
Pankraz76
Pankraz76 commented Jul 31, 2025
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the extract-qa branch 2 times, most recently from 38ad85c to f3c968b Compare July 31, 2025 08:42
@Pankraz76

This comment was marked as resolved.

Sign in to view
@Pankraz76 Pankraz76 force-pushed the extract-qa branch 2 times, most recently from 1087735 to bb1fbc0 Compare July 31, 2025 15:12
@Pankraz76
Copy link
Author

seem this to be the breaking change. SOC always wins.

@Pankraz76 Pankraz76 changed the title MINOR: Split gradle plugin config of quality gates (spotless, spotbugs, and checkstyle) into dedicated files MINOR: Split gradle root config into dedicated sections Aug 1, 2025
@Pankraz76 Pankraz76 mentioned this pull request Aug 5, 2025
Closed
@Pankraz76
Copy link
Author

BUILD SUCCESSFUL in 1m 31s

kindly request some feedback. Should we split this as well extracting the qa plugins in next pr?

@Pankraz76
Copy link
Author

i can confirm no one cares about the code quality at all, facing the masses of unused declaration and flaws around. Good luck.

@Pankraz76 Pankraz76 closed this Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Gradle build or GitHub Actions ci-approved clients consumer tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pankraz76 @m1a2st