Skip to content

MINOR: Cleanup Server Module #20180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

sjhajharia
Copy link
Contributor

As the PR title suggests, this PR is an attempt to perform some cleanups in the server module. The changes are mostly around the use of Record type for some classes, changes to use enhanced switch, etc.

@github-actions github-actions bot added triage PRs from the community core Kafka Broker labels Jul 16, 2025
@sjhajharia
Copy link
Contributor Author

Hey @chia7712
A minor PR for review.

Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

public Uuid memberId() {
return memberId;
}

@Override
public int hashCode() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the implementation is equal to generated code, please remove them to simplify the code base :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hashCode() method is needed if we have an equals() method defined. And given that we have a slightly different equals() method than the default one, i think we need to preserve both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And given that we have a slightly different equals() method than the default one

pardon me, what is the difference between these two implementations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was reading the code a bit wrong. I see the point you are trying to make. I have updated the PR accordingly.

@github-actions github-actions bot removed the triage PRs from the community label Jul 23, 2025
@sjhajharia sjhajharia requested a review from chia7712 July 23, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants