-
Notifications
You must be signed in to change notification settings - Fork 14.5k
MINOR: Cleanup Server Module #20180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
MINOR: Cleanup Server Module #20180
Conversation
Hey @chia7712 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
public Uuid memberId() { | ||
return memberId; | ||
} | ||
|
||
@Override | ||
public int hashCode() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the implementation is equal to generated code, please remove them to simplify the code base :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hashCode()
method is needed if we have an equals()
method defined. And given that we have a slightly different equals() method than the default one, i think we need to preserve both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And given that we have a slightly different equals() method than the default one
pardon me, what is the difference between these two implementations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was reading the code a bit wrong. I see the point you are trying to make. I have updated the PR accordingly.
As the PR title suggests, this PR is an attempt to perform some cleanups in the server module. The changes are mostly around the use of Record type for some classes, changes to use enhanced switch, etc.