MINOR: Cleanup Server Module #20180
Open
MINOR: Cleanup Server Module #20180
+416
−539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chia7712 |
chia7712
reviewed
Jul 22, 2025
| public Uuid memberId() { | ||
| return memberId; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
If the implementation is equal to generated code, please remove them to simplify the code base :)
There was a problem hiding this comment.
The hashCode() method is needed if we have an equals() method defined. And given that we have a slightly different equals() method than the default one, i think we need to preserve both.
There was a problem hiding this comment.
And given that we have a slightly different equals() method than the default one
pardon me, what is the difference between these two implementations?
There was a problem hiding this comment.
Sorry, I was reading the code a bit wrong. I see the point you are trying to make. I have updated the PR accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the PR title suggests, this PR is an attempt to perform some cleanups in the server module. The changes are mostly around the use of Record type for some classes, changes to use enhanced switch, etc.