[WIP] KAFKA-19012: Messages ending up on the wrong topic #20146
+384
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding instrumentation for KafkaProducer to detect when the topic a message was written to changes after it's enqueued.
…rs would be empty
Updated updateInconsistentTopics to accept the batch's TopicPartition and Records instead of passing in the ProducerBatch directly.
Introduces a dedicated class to perform instrumentation at points before decompression is required.
…ducer/internals/SenderMetricsRegistry.java
junrao
reviewed
Jul 17, 2025
| @@ -127,6 +128,7 @@ public RecordAccumulator(LogContext logContext, | |||
| Time time, | |||
| ApiVersions apiVersions, | |||
| TransactionManager transactionManager, | |||
| Kafka19012Instrumentation kafka19012Instrumentation, | |||
There was a problem hiding this comment.
Could you add the javadoc for the new param?
…csRegistry.TOPIC_METRIC_GROUP_NAME
junrao
reviewed
Jul 17, 2025
| @@ -127,6 +128,7 @@ public RecordAccumulator(LogContext logContext, | |||
| Time time, | |||
| ApiVersions apiVersions, | |||
| TransactionManager transactionManager, | |||
| Kafka19012Instrumentation kafka19012Instrumentation, | |||
There was a problem hiding this comment.
Could you add the javadoc for the new param?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding instrumentation for
KafkaProducerto detect when the topic a message was written to changes after it's enqueued.