Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18307: Don't report on disabled/removed tests #18318

Merged
merged 5 commits into from
Jan 6, 2025
Merged

KAFKA-18307: Don't report on disabled/removed tests #18318

merged 5 commits into from
Jan 6, 2025

Conversation

santhoshct
Copy link
Contributor

@santhoshct santhoshct commented Dec 26, 2024 •
edited
Loading

  • Corrected the timezone for develocity links
  • Corrected the counts in the table summary

Test results:
https://gist.github.com/santhoshct/46ba1307ae02a97942c544bb25c61f89

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions labels Dec 26, 2024
@ijuma ijuma requested a review from mumrah December 27, 2024 01:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@mumrah mumrah changed the title KAFKA-18307: bug fix KAFKA-18307: Don't report on disabled/removed tests Jan 6, 2025
mumrah
mumrah approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally and it seems to work. On trunk, the report includes KafkaRaftClientTest#testInitializeAsResignedAndOnlyVoter which is not committed yet.

@mumrah mumrah merged commit e546b02 into apache:trunk Jan 6, 2025
4 checks passed
@mumrah
Copy link
Member

mumrah commented Jan 6, 2025

@santhoshct I filed https://issues.apache.org/jira/browse/KAFKA-18416 as a follow-up. I noticed we are missing some flaky tests in the report.

@github-actions github-actions bot removed the triage PRs from the community label Jan 7, 2025
@santhoshct
Copy link
Contributor Author

@mumrah created PR to address the above filed issue. #18434

manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@santhoshct @manoj-mathivanan
KAFKA-18307: Don't report on disabled/removed tests (apache#18318)
13d2dae 
This patch ensures we only analyze trunk builds for the Develocity report. Some other minor fixes are also included

Reviewers: David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumrah mumrah mumrah approved these changes

Assignees
No one assigned
Labels
build Gradle build or GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santhoshct @mumrah