Repository navigation
GH-4343: Restore @Test on two jena-arq tests lost in the JUnit 5 conversion - #4344
Open
sharanggupta wants to merge 2 commits into
Open
sharanggupta wants to merge 2 commits into
sharanggupta wants to merge 2 commits into
Conversation
…5 conversion apacheGH-3306 replaced @test(expected = ...) with assertThrows in TestTokenizerText.tokenizer_charset_uri_1 and AbstractTestTransactionLifecycle.transaction_err_nontxn_commit_1 but dropped their @test, so they stopped running.
Add @test to TestTokenizerText.token_replacementChar_uri_1 and token_replacementChar_uri_2, and to TestLangTurtle.turtle_rdf12_05 with the final DOT added to its input. Remove TestExpressions.string_25 and string_26, which never ran and are wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #4343
Pull request Description:
The JUnit 5 conversion (GH-3306) replaced
@Test(expected = ...)withassertThrowsinTestTokenizerText.tokenizer_charset_uri_1andAbstractTestTransactionLifecycle.transaction_err_nontxn_commit_1but dropped their@Test, so they stopped running. This restores the annotation on both.As discussed in #4343, it also:
@TesttoTestTokenizerText.token_replacementChar_uri_1andtoken_replacementChar_uri_2;@TesttoTestLangTurtle.turtle_rdf12_05, with the final DOT added to its input (the parser accepting it without the DOT is Turtle parsing does not accept a final reified triple with a DOT in non-strict mode. #4347);TestExpressions.string_25andstring_26.TestTokenizerText(212 tests),TestLangTurtle(47),TestExpressions(293) andTestDatasetGraphInMemoryTransactions(52) pass.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.