GH-2340: Remove the server-per-testsuite switch from Fuseki tests - #4133
Merged
Conversation
…ts and replace with default 'on'
Member
|
Any string "resolved: #2340" will close the issue. The computer does not read "(partially)". Description edited so it doesn't happen. |
afs
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: '#2340' (Partially)
Pull request Description:
This PR is a continuation of #4131, this time tackling the existing support for turning server-per-test on/off. This functionality was only used in a handfull of tests, maybe this mechanism existed for testing the intermittent failures. Either way, they were removed and the tests use the same mechanism from the previous PR. Because these tests already had their own server, I don't think there are any to worry about that might depend on state from the other. The only thing that I'm noting is that the test harnesses are starting to repeat themselves between the previous PR and this one.
TestFusekiShaclValidation2.javawas deleted, as it looks like one of the tests that was trying to isolate a failure (These are optimistic changes).The changes should look pretty familiar, with the change pattern about the same in the linked pull request.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.