Repository navigation
Fix stop-edge.bat to honor predefined IOTDB_HOME from environment - #19044
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
scripts/sbin/windows/start-edge.bat,stop-datanode.bat, andstop-standalone.bat, any existingIOTDB_HOMEenvironment variable is honored usingif NOT DEFINED IOTDB_HOME set "IOTDB_HOME=%cd%".However,
stop-edge.batunconditionally executedset "IOTDB_HOME=%cd%". If an IoTDB Edge node was started withIOTDB_HOMEset to an explicit path (e.g., via a symbolic link, junction, or custom configuration path),start-edge.batlaunched the JVM process with-DIOTDB_HOME="..."using that environment variable, butstop-edge.batoverwroteIOTDB_HOMEwith the physical resolved path. This preventedstop-edge.batfrom matching and stopping the runningjava.exeprocess.Fixes #19005.
Changes
scripts/sbin/windows/stop-edge.batto checkif NOT DEFINED IOTDB_HOME set "IOTDB_HOME=%cd%", consistent withstart-edge.batand the other Windows stop scripts.Checklist
git commit -s)