Skip to content

Fix consensus subscription WAL retention and replay cursor - #19042

Open
Caideyipi wants to merge 1 commit into
masterfrom
fix/subscription-wal-roll-retention-20261028
Open

Fix consensus subscription WAL retention and replay cursor#19042
Caideyipi wants to merge 1 commit into
masterfrom
fix/subscription-wal-roll-retention-20261028

Fix consensus subscription WAL retention and replay cursor

efc5310
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 28, 2026 in 5m 47s

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 166 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/ChunkPayloadRef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'ChunkPayloadUnavailableException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNrhVPWSXd-YsPvi1&open=AaGCNrhVPWSXd-YsPvi1&pullRequest=19042

Check warning on line 2218 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof ProjectNode project' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNsEOPWSXd-YsPvjI&open=AaGCNsEOPWSXd-YsPvjI&pullRequest=19042

Check warning on line 95 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/LogWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Error. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNq9NPWSXd-YsPvib&open=AaGCNq9NPWSXd-YsPvib&pullRequest=19042

Check warning on line 29 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALFormatException.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'WALFormatException' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNq2JPWSXd-YsPviS&open=AaGCNq2JPWSXd-YsPviS&pullRequest=19042

Check warning on line 2407 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 130). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNtwYPWSXd-YsPvkN&open=AaGCNtwYPWSXd-YsPvkN&pullRequest=19042

Check failure on line 466 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/AlignedChunkData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use try-with-resources or close this "ByteBufferOutputStream" in a "finally" clause. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNrswPWSXd-YsPvi7&open=AaGCNrswPWSXd-YsPvi7&pullRequest=19042

Check failure on line 551 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNvGXPWSXd-YsPvk3&open=AaGCNvGXPWSXd-YsPvk3&pullRequest=19042

Check warning on line 4271 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invert this negated condition and swap the two branches of the ternary. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNsi7PWSXd-YsPvjX&open=AaGCNsi7PWSXd-YsPvjX&pullRequest=19042

Check warning on line 666 in iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/relational/IoTDBRelationalDatabaseMetadata.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNwMrPWSXd-YsPvlg&open=AaGCNwMrPWSXd-YsPvlg&pullRequest=19042

Check warning on line 461 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/TreeToTableViewCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'}' at column 43 should be alone on a line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNtluPWSXd-YsPvj_&open=AaGCNtluPWSXd-YsPvj_&pullRequest=19042

Check warning on line 576 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNvGXPWSXd-YsPvkx&open=AaGCNvGXPWSXd-YsPvkx&pullRequest=19042

Check warning on line 378 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this private field "final", it is never reassigned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNre8PWSXd-YsPvix&open=AaGCNre8PWSXd-YsPvix&pullRequest=19042

Check warning on line 140 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/read/reader/chunk/DiskAlignedChunkLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Error. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNrIHPWSXd-YsPvip&open=AaGCNrIHPWSXd-YsPvip&pullRequest=19042

Check warning on line 1209 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "new String[]" prefix; the declaration already specifies the array type. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNuM7PWSXd-YsPvkd&open=AaGCNuM7PWSXd-YsPvkd&pullRequest=19042

Check warning on line 1578 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'MetadataException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNu-LPWSXd-YsPvku&open=AaGCNu-LPWSXd-YsPvku&pullRequest=19042

Check warning on line 91 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadPointCompactionPerformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this private field "final", it is never reassigned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNqbiPWSXd-YsPvh0&open=AaGCNqbiPWSXd-YsPvh0&pullRequest=19042

Check warning on line 123 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALRecoverManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNqn1PWSXd-YsPvh_&open=AaGCNqn1PWSXd-YsPvh_&pullRequest=19042

Check warning on line 506 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/DataNodeTableCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 117). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNtpAPWSXd-YsPvkH&open=AaGCNtpAPWSXd-YsPvkH&pullRequest=19042

Check warning on line 114 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/relational/function/tvf/match/QetchAlgorithm.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 107). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNpvaPWSXd-YsPvht&open=AaGCNpvaPWSXd-YsPvht&pullRequest=19042

Check warning on line 299 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/PredicateUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Summary javadoc is missing. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNslPPWSXd-YsPvjY&open=AaGCNslPPWSXd-YsPvjY&pullRequest=19042

Check warning on line 84 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/LogWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Error. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNq9NPWSXd-YsPvia&open=AaGCNq9NPWSXd-YsPvia&pullRequest=19042

Check warning on line 494 in iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/relational/IoTDBRelationalDatabaseMetadata.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'SQLException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNwMrPWSXd-YsPvln&open=AaGCNwMrPWSXd-YsPvln&pullRequest=19042

Check warning on line 45 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALFileContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'IOException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNqz4PWSXd-YsPviQ&open=AaGCNqz4PWSXd-YsPviQ&pullRequest=19042

Check warning on line 426 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 120). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNs4LPWSXd-YsPvji&open=AaGCNs4LPWSXd-YsPvji&pullRequest=19042

Check warning on line 74 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/ViewColumnAutoSyncTrigger.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGCNtmWPWSXd-YsPvkA&open=AaGCNtmWPWSXd-YsPvkA&pullRequest=19042
View more details on SonarQubeCloud