Fix write retries, Pipe resource cleanup, subscription progress, and snapshot recovery#18180
Merged
jt2594838 merged 7 commits intoJul 15, 2026
Merged
Conversation
…te-pipe-snapshot-recovery
…shot-recovery-pr18180
jt2594838
approved these changes
Jul 15, 2026
jt2594838
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes partial-failure and recovery edge cases across the write path, Pipe, subscription progress, and ConfigNode snapshots. These bugs could replay data that had already been written, report unwritten rows as successful, leak generated TsFiles or reserved memory, retain stale state after recovery, replay pre-subscription rows, or skip the first pending row after a consensus subscription owner transfer.
Keep write retries and failure reporting consistent
Make Pipe conversion and transfer failure-safe
Preserve subscription commit progress safely
Synchronize consensus subscription initial frontiers
Replace stale state during snapshot loading
Verification
mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/datanode,iotdb-core/confignodeCommitProgressKeeperTest,QuotaInfoTest,TemplateTableTest,TemplatePreSetTableTest,PipeTsFileBuilderV2Test,DataRegionTest, andTsFileProcessorTest.CommitProgressKeeperTest,ConfigManagerCommitProgressTest,CommitProgressSyncProcedureTest,CreateSubscriptionProcedureTest,SubscriptionConsumerAgentTest,ConsensusPrefetchingQueueTest,ConsensusSubscriptionCommitStateTest, andConsensusSubscriptionSetupHandlerTest.IoTDBConsensusSubscriptionColumnFilterClusterIT#testAlterColumnFilterRebindsAfterOwnerTransferOnThreeDataNodespassed three consecutive cluster runs.mvn -o -nsu test-compile -DskipTests -Pwith-zh-locale.git diff --checkpassed.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
DataRegion,TsFileProcessor, andHashLastFlushTimeMapCommitProgressKeeper,ConsensusSubscriptionCommitManager,ConsensusSubscriptionSetupHandler,ConsensusPrefetchingQueue, andProgressWALIteratorConfigManager,CommitProgressSyncProcedure, andCreateSubscriptionProcedureTemplateTable,TemplatePreSetTable,QuotaInfo, andExternalServiceInfoPipeConfigRegionListener,AbstractSerializableListeningQueue, andConcurrentIterableLinkedQueue