-
Notifications
You must be signed in to change notification settings - Fork 262
#626: Add routing field in metadata - Solr StatusUpdaterBolt #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/StatusUpdaterBolt.java
Outdated
Show resolved
Hide resolved
do we need doRouting at all? Not sure how the routing is done for SOLR, is it via the collection definition or the indexing API as in OpenSearch? |
At least the variable is never used, so might be dropped. |
I'm aware that
If I'm not mistaken it depends on the |
yes please, let's add it back later with the rest of the code that relies on it
I suppose what we need is to use
and point it to the key field, otherwise it will take the unique document key. Is that correct? |
Yes, you are right - thanks for noting! |
where should |
Thanks for the patience - I just found some time to look again into this :-)
I don't think this will work. The So, for #620 we could do the following:
|
Yes, this variable is #620 related and was unused. I removed it for this PR. |
Thanks @mvolikas |
#626 Now one can specify a routing key, which is added to the status metadata.