-
Notifications
You must be signed in to change notification settings - Fork 77
[WIP] add remove vertex edge, TODO: tests #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
============================================
+ Coverage 76.48% 76.51% +0.02%
- Complexity 535 564 +29
============================================
Files 82 83 +1
Lines 8638 8720 +82
Branches 1001 1011 +10
============================================
+ Hits 6607 6672 +65
- Misses 1815 1828 +13
- Partials 216 220 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yangxk1 Do we need to consider the adjacency list when deleting a vertex/edge? where do you test |
Do you mean that delete adjacency list in edgeInfo?
I don't think we tested |
Ok, where is the yaml file, to load a sample testing graph from which i can add or remove vertex and validate? |
|
In incubator-graphar/maven-projects/info/src/test/java/org/apache/graphar/info/GraphInfoTest.java Line 39 in b7768ad
|
|
@unical1988 , please note that runs |
yangxk1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
please run git submodule update --remote to update testing data submodule
| <version>${spotless-maven-plugin.version}</version> | ||
| <configuration> | ||
| <java> | ||
| <!--<includes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remember to delete this line
Reason for this PR
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?