Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-24059 Reuse compute serialization in client and embedded APIs #5017

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

IGNITE-24059 Reuse compute serialization in client and embedded APIs #5017

wants to merge 57 commits into from
+643 −736

Conversation

ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Jan 9, 2025 •
edited
Loading

  • Extract common logic to SharedComputeUtils, reuse in client and embedded APIs
  • Always use ComputeJobDataHolder to pass argument and result data around internally
    • Before that we used internal message serialization for args and results in some cases, resulting in inconsistent behavior

ptupitsyn added 30 commits January 9, 2025 10:26
@ptupitsyn
IGNITE-24059 Reuse Compute serialization across client and embedded APIs
c6934db
@ptupitsyn
Extract packCollectionToBinaryTuple
ff5a3d0
@ptupitsyn
Extract packCollectionToBinaryTuple
5a6d763
@ptupitsyn
Extract readTupleCollection
9816a8c
@ptupitsyn
wip tests
6682916
@ptupitsyn
wip tests
ebb21f8
@ptupitsyn
extract marshalAndWrapArgOrResult
e69b148
@ptupitsyn
Extract unmarshalArgOrResult
45f096b
@ptupitsyn
Extract unmarshalArgOrResult - ClientComputeJobUnpacker cleanup
ef9a100
@ptupitsyn
SharedComputeUtils cleanup
68c3c79
@ptupitsyn
wip TODOs
50d7a3c
@ptupitsyn
Refactor compute impl to pass around ComputeJobDataHolder
29e202e
@ptupitsyn
Refactor compute impl to pass around ComputeJobDataHolder - wip
a8ba7d5
@ptupitsyn
Refactor compute impl to pass around ComputeJobDataHolder - wip
91a5ce6
@ptupitsyn
Refactor compute impl to pass around ComputeJobDataHolder - wip - bui…
6303f4d 
…ld mostly fixed
@ptupitsyn
Refactor test latch jobs
a2c13de
@ptupitsyn
Fixing job result deserialization and ComputeJobDataHolder propagation
411b010
@ptupitsyn
Fixing job result deserialization and ComputeJobDataHolder propagatio…
ac41864 
…n - fix ResultUnmarshallingJobExecution
@ptupitsyn
Fixing job result deserialization and ComputeJobDataHolder propagatio…
e9a6518 
…n - fix IgniteComputeImpl
@ptupitsyn
Fix build - executesColocatedWithTupleKeyAsync now works
d5e8120
@ptupitsyn
wip
80a7a1c
@ptupitsyn
Fixing executeLocally
00cff98
@ptupitsyn
Fixing executeLocally
4ef559d
@ptupitsyn
Fixing executeLocally - localExecutionActuallyUsesLocalNode works
7154b3a
@ptupitsyn
wip
7b283d5
@ptupitsyn
wip
e71ef7e
@ptupitsyn
wip task result
90e4769
@ptupitsyn
fixing tests
ed84430
@ptupitsyn
ItComputeTestEmbedded fixed
f7a4dee
@ptupitsyn
Fix executesJobWithNonExistingUnit
de432f2
@ptupitsyn ptupitsyn self-assigned this Jan 9, 2025
@ptupitsyn ptupitsyn changed the title IGNITE-24059 Reuse Compute serialization across client and embedded APIs IGNITE-24059 Reuse Compute serialization in client and embedded APIs Jan 10, 2025
@ptupitsyn ptupitsyn changed the title IGNITE-24059 Reuse Compute serialization in client and embedded APIs IGNITE-24059 Reuse compute serialization in client and embedded APIs Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ptupitsyn ptupitsyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ptupitsyn