Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions open-api/rest-catalog-open-api.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,11 @@ class Config:

class CreateNamespaceResponse(BaseModel):
namespace: Namespace
namespace_uuid: str | None = Field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to put this under the Namespace itself as an optional field, similar to how it's done for TableMetadata/ViewMetadata. We will then most likely need a separate NamespaceParser that reads/writes that optional uuid. Right now we only have a NamespaceSerializer and NamespaceDeserializer which serDe the levels of the namespace directly

None,
alias='namespace-uuid',
description='Optional UUID representing the unique identifier for the namespace. This is tied to the actual entity, not the name, which can be reused.',
)
properties: dict[str, str] | None = Field(
{},
description='Properties stored on the namespace, if supported by the server.',
Expand All @@ -740,6 +745,11 @@ class CreateNamespaceResponse(BaseModel):

class GetNamespaceResponse(BaseModel):
namespace: Namespace
namespace_uuid: str | None = Field(
None,
alias='namespace-uuid',
description='Optional UUID representing the unique identifier for the namespace. This is tied to the actual entity, not the name, which can be reused.',
)
properties: dict[str, str] | None = Field(
{},
description='Properties stored on the namespace, if supported by the server. If the server does not support namespace properties, it should return null for this field. If namespace properties are supported, but none are set, it should return an empty object.',
Expand Down
6 changes: 6 additions & 0 deletions open-api/rest-catalog-open-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4102,6 +4102,9 @@ components:
properties:
namespace:
$ref: '#/components/schemas/Namespace'
namespace-uuid:
type: string
description: "Optional UUID representing the unique identifier for the namespace. This is tied to the actual entity, not the name, which can be reused."
properties:
type: object
additionalProperties:
Expand All @@ -4118,6 +4121,9 @@ components:
properties:
namespace:
$ref: '#/components/schemas/Namespace'
namespace-uuid:
type: string
description: "Optional UUID representing the unique identifier for the namespace. This is tied to the actual entity, not the name, which can be reused."
properties:
type: object
description:
Expand Down