Enable to configure metrics-publisher in AWS client factory#15304
Enable to configure metrics-publisher in AWS client factory#15304rmannibucau wants to merge 3 commits intoapache:mainfrom
Conversation
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
The PR #15122 also proposes a metrics publisher; it's probably best to see how that PR suits you and what bits of this you think need to be pulled in.
I like the tests here
| factory.initialize( | ||
| Map.of( | ||
| // CRT impl is still not equivalent to the default java one | ||
| "s3.crt.enabled", "false", |
There was a problem hiding this comment.
just a source of a different stack traces...
There was a problem hiding this comment.
not sure I got this one, issue is CRT doesn't support metrics publisher so I disable it explicitly in tests
|
#15122 works for me but doesnt expose any configuration - not a blocker here since I end up storing in a static copyonwritelist the instances to wire them in a spark sink but I assume we want to align the model on credential provider one? No issue to close this PR if the other one is preferred while it hits a release at some point :) |
|
just suggesting you work together to produce something which you both find works, as that's how best to get something in which suits more people |
|
@rcjverhoef do you want to add the properties filter + |
2 participants
No description provided.